Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: x-tile - A GNOME panel applet to tile windows https://bugzilla.redhat.com/show_bug.cgi?id=554760 Summary: Review Request: x-tile - A GNOME panel applet to tile windows Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@xxxxxxxxxxxxxxxxx ReportedBy: pikachu.2014@xxxxxxxxx QAContact: extras-qa@xxxxxxxxxxxxxxxxx CC: notting@xxxxxxxxxx, fedora-package-review@xxxxxxxxxx Estimated Hours: 0.0 Classification: Fedora Spec URL: http://melmorabity.fedorapeople.org/packages/x-tile/x-tile.spec SRPM URL: http://melmorabity.fedorapeople.org/packages/x-tile/x-tile-1.3-1.fc12.src.rpm Description: X-tile is a GNOME applet for your panel (or optionally a standalone application) that allows you to select a number of windows and tile them in different ways. This is especially useful for comparing products in separate web pages, or for programmers refering to documentation as they are programming. This package requires python-psutil (see bug 554714) to work. This package builds fine on mock. About rpmlint : * on SRPM: x-tile.src:40: E: hardcoded-library-path in %{_prefix}/lib/bonobo/servers A library path is hardcoded to one of the following paths: /lib, /usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}. x-tile.src:41: E: hardcoded-library-path in %{_prefix}/lib/bonobo/servers A library path is hardcoded to one of the following paths: /lib, /usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}. x-tile.src:64: E: hardcoded-library-path in %{_prefix}/lib/bonobo/servers/*.server A library path is hardcoded to one of the following paths: /lib, /usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}. * on RPM: x-tile.noarch: E: explicit-lib-dependency libbonobo You must let rpm find the library dependencies by itself. Do not put unneeded explicit Requires: tags. For this last issue, I had to add an explicit Requires on libbonobo which owns the folder /usr/lib/bonobo/servers. The package installs a .server in this directory. Note that libbonobo.x86_64 owns both /usr/lib64/bonobo/servers and /usr/lib/bonobo/servers. To avoid to make my package arch-specific although there is no binary, I choosed to install the .server file delivered with the sources explicitely in /usr/lib/bonobo/servers. This folder is taken into account by libbobobo even in x86_64 platforms, so no particular issue is expected in x86_64. I don't know if there is a macro to avoid an explicit reference to "lib" to make rpmlint silent, I found nothing special about this when doing a grep on both /etc/rpm/ and /usr/lib/rpm/ ^^ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review