Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ssmtp https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188400 ------- Additional Comments From pertusus@xxxxxxx 2006-10-07 11:58 EST ------- I have some comments: * it is still wrong to provide the man pages, especially for man pages corresponding with commands that do nothing in ssmtp * it seems very dubious to me to Provides: %{_bindir}/mailq %{_bindir}/newaliases since these do nothing with ssmtp * the patch ssmtp-2.61.6.patch seems to be a debian patch. I think it should be marked as such, the file name would better be the one in debian, and it would also be nice to have a comment telling what vulnerabilities are fixed. (I guess it is even possible to have an url in %Patch if you like). And it doesn't seems to be the latest version in debian unstable. Is there a reason? * you could add -p switch to install when the file is from upstream since it keeps the timestamp. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review