Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=549593 --- Comment #1 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> 2010-01-11 22:46:23 EST --- Please update the package to 0.1.1 before I do the full review. Some first comments: - make should be verbose (V=1) - missing Build requires intltool and gettext doesn't build in mock because of Build Configuration: * Debug: minimum Plugins: * GdkPixbuf thumbnailer plugin: no * FreeType font thumbnailer plugin: no * JPEG thumbnailer plugin with EXIF support: no * Freedesktop.org cache plugin: no - removing rpath with sed should be preferred over chkrpath https://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath %dir %{_datadir}/gtk-doc/html/tumbler %doc %{_datadir}/gtk-doc/html/tumbler/* is the same as %doc %{_datadir}/gtk-doc/html/tumbler/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review