Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=554089 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tomspur@xxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tomspur@xxxxxxxxxxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-01-11 10:33:03 EST --- To be honest, the review can be mostly copy & paste from pybox2d... Review: Good: - name ok - license ok - sources match upstream (diff -r clean) - BR ok - rpmlint clean $ rpmlint python-elements-0.13-1.20100110svn.fc12.src.rpm noarch/python-elements-0.13-1.20100110svn.fc12.noarch.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. - %clean is there - %install ok (calm rpmlint down, can't be moved to %prep) - description ok - permissions ok - %files ok - builds in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1914151 Needswork: - How to create the tarball... Copy paste of your command does not work... Remove the '|' and it'll work. - calm rpmlint down in %prep and not in %install -> sed -i elements/elements.py -e 1d - use global and not define: https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define - why is the group devel/languages? Development/Libraries would be more appropriate. ######################### Change the group to Development/Libraries and calm rpmlint down in %prep, the rest is 'should'. ######################### APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review