Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: comix - A user-friendly, customizable image viewer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209617 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-10-06 20:23 EST ------- Hmm, the source doesn't match upstream. Ahh, because the source URL gives me some HTML for selecting a mirror. You should use dl.sourceforge.net instead of prdownloads.sourceforge.net. I also had to manually add a mirror (easynews) in order to actually download the source, since the sourceforge mirror system is so broken. The non-conffile-in-etc bit is known to be bogus for gconf schemas. This package owns /etc/gconf, which is owned by GConf in FC5 but which is completely unowned in FC6. Ouch. This package also owns /etc/gconf/schemas, which unfortunately doesn't seem to be owned by GConf as it should. I really don't know what this package should do; I guess owning those directories is better than leaving them unowned, but this should be fixed in Core and if it is this package will need to stop owning those directories. So I'll approve this package for FC6/rawhide, but for FC5 you will need to stop owning /etc/gconf. * source files match upstream: 2d6034c5c032fcb5fe257048d64364a8 comix-3.6.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint has only bogus complaints. * final provides and requires are sane: comix = 3.6-1.fc6 = /bin/sh /usr/bin/env /usr/bin/jpegtran GConf2 pygtk2 python-imaging * %check is not present; no test suite upstream. Package manually tested and seems to work fine. * owns the directories it creates. ? owns /etc/gconf; in FC5, it must not. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (gconf schema installation, icon cache update, desktop database update, mime database update) * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * .desktop file installed properly APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review