Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551743 --- Comment #7 from Felix Kaechele <felix@xxxxxxxxxx> 2010-01-10 14:51:30 EST --- Here's the review: [!] source files match upstream: 1f4ce6c898cbf0472a2ab9871ecbe2429c89ceb91424f45bddc7324c92da051e cnucnu-7b50751529ece79992f1dc2bd16c7931929214c3.tar.gz 43c64f843f378348819eeb3b449da17a51139414c56e39c2cb839b00b82cad91 cnucnu-7b50751529ece79992f1dc2bd16c7931929214c3.tar.gz.orig [+] package meets naming and versioning guidelines. [+] spec is properly named, cleanly written, and uses macros consistently. [+] dist tag is present. [+] build root is correct. [+] license field matches the actual license. [+] license is open source-compatible. [+] license text included in package. [+] latest version is being packaged. [+] BuildRequires are proper. [NA] compiler flags are appropriate. [+] %clean is present. [+] package builds in mock. [+] package installs properly. [NA] debuginfo package looks complete. [+] rpmlint is silent. [+] final provides and requires are sane [NA] %check is present and all tests pass: [NA] no shared libraries are added to the regular linker search paths. [+] owns the directories it creates. [+] doesn't own any directories it shouldn't. [+] no duplicates in %files. [+] file permissions are appropriate. [NA] scriptlets match those on ScriptletSnippets page. [+] code, not content. [+] documentation is small, so no -docs subpackage is necessary. [+] %docs are not necessary for the proper functioning of the package. [+] no headers. [+] no pkgconfig files. [+] no libtool .la droppings. [NA] desktop files valid and installed properly. The only thing keeping me from approving this package is that I still can't verify the integrity of the snapshot. This is a bit odd because a diff -qrN against the extracted files of the provided source and the extracted files of the snapshot I downloaded clearly tells me that there is no difference. Maybe that is due to the way gitweb creates it's snapshots. However I would feel more comfortable if someone else could confirm this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review