Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545039 Peter Robinson <pbrobinson@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |pbrobinson@xxxxxxxxx --- Comment #6 from Peter Robinson <pbrobinson@xxxxxxxxx> 2010-01-10 07:20:59 EST --- Some initial comments, and if you can the so an updated package I'll do a full review - no gecko-devel-unstable in rawhide. I think its all in xulrunner-devel now? - no %{nspr_version} but AFAICT it would be the same version as required by xulrunner-devel it should automatically be pulled in so is redundant - Summary/Description could be improved "Files needed to run" is sort of redundant - I think you need to explicitly list files - doesn't build in koji http://koji.fedoraproject.org/koji/taskinfo?taskID=1912043 Needs at least: BuildRequires: autoconf213 BuildRequires: python-devel It then builds on x64 but not 32 bit http://koji.fedoraproject.org/koji/taskinfo?taskID=1912049 - No need for empty %preun -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review