Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=554082 Dan Horák <dan@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dan@xxxxxxxx --- Comment #1 from Dan Horák <dan@xxxxxxxx> 2010-01-10 07:10:18 EST --- few notes: - the %global definition at the top are redundant, the same is achieved when the values are placed into Name, Version and Release tags - Release must be > 0 and incremented for each iteration when the version remains the same - value of License is not valid - see https://fedoraproject.org/wiki/Licensing for available values - %setup -q -n pam_radius_auth-%{version} is equivalent to simple %setup -q - ownership and permissions for /etc/raddb/server should be set in %files section with "%attr(root,root, 0600) %config()..." - the /etc/raddb directory must be owned by the package (%dir %{_sysconfdir}/raddb) and then it is properly removed on uninstall - use %{_sysconfigdir} instead of /etc - you can learn from some other pam module available at http://cvs.fedoraproject.org/viewvc/rpms/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review