Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529374 --- Comment #26 from Peter Robinson <pbrobinson@xxxxxxxxx> 2010-01-09 11:31:13 EST --- Thanks for these updates Christoph, I was quite clearly not with it when doing this package to have missed those. October was somewhat of a blur :-( > Sorry, but there are definitely blockers left: > - the unversioned libs in /usr/lib64/ethos/plugin-loaders/ belong into the > devel package Fixed. > - using %{_libdir}/python2.6/ in the files section is a no-go. Please see > https://fedoraproject.org/wiki/Packaging/Python#System_Architecture > for how to do this properly. > - vala package should be noarch as it contains no arch dependent files Fixed. > > It should be this package that owns it. > > > > > gobject-introspection-devel-0:0.6.7-1.fc13.i686 Fixed. > Then you need the devel package require gobject-introspection-devel for > directory ownership. Currently the requirements autogenerated from the pkconfig > files only include > pkgconfig(gobject-2.0) > pkgconfig(gtk+-2.0) > This means that only glib2-devel and gtk2-devel are pulled in. And even if we > had pkgconfig(introspection-1.0.pc) I'd still prefer requiring > gobject-introspection-devel because all this stuff only works with newer > versions of rpm. For some reason I thought this was done automatically now. Don't see RPM version really as an issue as I don't plan to push it to anythin earlier than F-12. Fixed anyway. > There are more potentially unowned dirs: > - doc package puts files into %{_datadir}/gtk-doc/html, so it needs to require > gtk-doc > - python package puts files into %{python_sitearch}/gtk-2.0 (sic!) and needs to > require pygtk2 > - python package puts files into %{_datadir}/pygtk/2.0/defs and needs to > require gnome-python2 > - vala package puts files into %{_datadir}/vala/vapi and needs to require vala Fixed. > Other questions: > - Why is there a doc package anway? Usually gtk-doc is part of the devel > package. People who don't want the docs can still install it with > --excludedocs. Because there was a push a while ago to move all docs into noarch packages to reduce the size of the overall mirror. > - Should %{_libdir}/ethos/plugin-loaders/libpythonloader.so be part of the > python package? Done. SRPM: http://pbrobinson.fedorapeople.org/ethos-0.2.2-4.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review