Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=552331 --- Comment #4 from Milos Jakubicek <xjakub@xxxxxxxxxx> 2010-01-09 09:28:34 EST --- - Please don't forget to bump the release number, otherwise it's just confusing! - Remove shadow-utils from Requires(postun) as well (as I wrote before). - Use %{_initddir} instead of %{_initrddir}, read: https://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_on_the_filesystem - Fix %config(noreplace) /etc/logrotate.d/piranha => %config(noreplace) %{_sysconfdir}/logrotate.d/piranha - patches documentation still missing - /etc/sysconfig misuse still unhandled - Remove the unnecessary Requires: popt (this will be added automatically by rpm) - Looking forward to see the new sources solving the licensing issues... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review