Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538820 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #2 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-01-08 04:09:38 EDT --- Some notes: * SourceURL - For sourceforge hosted tarball, please use: https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net By the way while I could download a tarball from http://downloads.sourceforge.net/roboptim/%{name}-%{version}.tar.gz , ^^^^^^^^^^^^^^^ the one I could download differs from the tarball in your srpm: ----------------------------------------------------------------- 498194 2009-11-17 21:53 original/roboptim-core-0.4.tar.gz 498224 2009-11-17 02:21 roboptim-core-0.4-1.fc11.src/roboptim-core-0.4.tar.gz ----------------------------------------------------------------- * Requires - "Requires: pkgconfig" on -devel package is no longer needed (on Fedora, not on EPEL) because Fedora rpmbuild automatically detects this dependency. - Requires: roboptim-core = %{version}-%{release} can be replaced with Requires: %{name} = %{version}-%{release} - As -devel subpackage contains the following files (for example) /usr/include/roboptim/core/function.hh: ---------------------------------------------------------------- 28 # include <boost/numeric/ublas/matrix.hpp> 29 # include <boost/numeric/ublas/vector.hpp> 30 # include <boost/tuple/tuple.hpp> ---------------------------------------------------------------- /usr/include/roboptim/core/solver-factory.hh ---------------------------------------------------------------- 26 # include <ltdl.h> ---------------------------------------------------------------- -devel subpackage should have "Requires: boost-devel" and "Requires: libtool-ltdl-devel" (here I am not saying about BuildRequires). ? pkgconfig file - By the way you specify configure option: ---------------------------------------------------------------- --docdir=%{_datadir}/doc/%{name}-%{version} ---------------------------------------------------------------- Does this mean that you have to modify docdir & doxygendocdir in build-aux/pkg-config.pc.in (and the installed roboptim-core.pc) ? * Non-library in %_libdir - What is the file "roboptim-core-dummy-plugin.so.1" in %_libdir? This file does not have the name "libXXXX.so.Y", so this does not seem to be a system-wide library, and this should be moved to some subdirectory under %_libdir (like %_libdir/%name). ! Note the reason rpmlint warns about "dangling-relative-symlink" on -devel package is because "roboptim-core-dummy-plugin.so.1" is not regarded as a library (because this file does not have the name libXXXX.so.Y) ( you can see that actually rpmlint does not show this waring on libroboptim-core.so ) * Timestamps - Please consider to use ----------------------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ----------------------------------------------------------------- to keep timestamps on installed files as much as possible. This method usually works for Makefiles generated by recent autotools. * About -doc subpackage - Currently only 5 files (AUTHORS COPYING THANKS README NEWS) are included in the -doc subpackage and I guess this is not what you expect. ! Note With the following lines ---------------------------------------------------------------- 64 %files 65 %defattr(-,root,root,-) 66 %doc AUTHORS COPYING THANKS README NEWS ---------------------------------------------------------------- rpmbuild - Firstly clean up the directory %buildroot%_docdir/%name-%version - Then again create the directory %buildroot%_docdir/%name-%version - and installs the files specified in %doc to this directory (please check build.log what is actually done by rpmbuild) Also please check if needed BuildRequies are correctly written. build.log says: ----------------------------------------------------------------- 336 make[3]: Nothing to be done for `install-exec-am'. 337 ../config.status --file="Doxyfile.extra":"Doxyfile.extra.in" 338 config.status: creating Doxyfile.extra 339 config.status: creating Doxyfile 340 sh: latex: command not found 341 sh: dvips: command not found 342 make[3]: Leaving directory `/builddir/build/BUILD/roboptim-core-0.4/doc' ----------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review