Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=544531 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #3 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-01-08 03:14:59 EDT --- Hello. Here are some notes: * Build / Mock - Your srpm does not build. http://koji.fedoraproject.org/koji/taskinfo?taskID=1908068 You can use "mock" to check if your srpm actually builds within a "clean" buildroot: http://fedoraproject.org/wiki/Extras/MockTricks Some notes: - source code actually requires "libXaw-devel" header files, not "Xaw3d-devel", based on the current location of the header files - Also "BR (BuildRequires): libXtst-devel" is missing - By default this installs some file under /usr/lib/X11/app-defaults, even on 64 bit architecture. This causes build failure on x86_64 (for example) because even with the following line -------------------------------------------------------------- %{__rm} -rf %{buildroot}/%{_libdir}/X11/app-defaults -------------------------------------------------------------- this cannot be deleted because on x86_64 %_libdir is expanded as /usr/lib64. I had to add "LIBDIR=%{_libdir}/X11" option to "make install" - Installed "normal" files should have 0644 permission, not 0444 permission. Modifying Makefile directly like ------------------------------------------------------------- %{__sed} -i.mode -e 's|-m 0444|-m 0644|' Makefile ------------------------------------------------------------- after xmkmf is simpler. - Please keep timestamps on installed files as much as possible: http://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps - When using "cp" or "install" commands add "-p" option - Also please consider to add 'INSTALLFLAGS="-c -p"' to "make install" * Source2 - Would you write how you obtained Source2? * Macros - Why do you also use %_datarootdir as well as %_datadir ? * Desktop file - "fedora-" prefix on the name is no longer needed. - "Application" in Categories is deprecated and should be removed. * %changelog - It is preferable (especially when using Fedora CVS system) to insert one line between each %changelog entry like: -------------------------------------------------------------- %changelog * Sat Dec 5 2009 Akio Idehara <zbe64533 at gmail.com> 3.0-2 - Add Desktop files * Sat Dec 5 2009 Akio Idehara <zbe64533 at gmail.com> 3.0-1 - Initial RPM release -------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review