Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529374 --- Comment #25 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> 2010-01-07 23:35:24 EDT --- The following are for Simon and Joesphine. They are of educational nature and not really related to the review: (In reply to comment #3) > The README file? Please look in the COPYING. This is the file to figure out the > correct license. Never (only) rely on a COPYING file, look into header of the sources instead. How would you destinguish between LGPLv2 or LGPLv2+ here by only looking at COPYING? (In reply to comment #10) > %{python_sitelib}/gtk-*/_%{name}.so > https://fedoraproject.org/wiki/Packaging:Python > > you should use %{name} instead of the name and you should use the "*" instead > of version numbers. It's easier for an mass rebuild; like a pygtk update. for > example the new path will be gkt-3.0 your specfile is valid for this and it is > nor required to edit it. I fully agree on %{python_sitelib}, but the rest is questionable: Using %{name} hardly adds any benefit. It only makes sense if Peter maintains lots of packages with similar specs, so he can copy & paste stuff there. Using a wildcard for the gtk version also doesn't add benefit. Once gtk3 lands this package definitely needs more than a scripted rebuild, it needs a new version. This version is supposed to work with gtk2, and different gtk major versions can be installed in parallel, so using gtk-2.0 is more sane and more obvious when you look at the spec. (In reply to comment #16) > The directory %{_datadir}/gtk-doc/html/ and all files/directories/etc > under this are automatically marked as %doc (check > $ rpm --eval %__docdir_path and /usr/lib/rpm/macros ) Of course Mamoru is right, but I still prefer marking this explicitly. I wanted to point out that it's important to check that files are correctly marked as %doc or %config. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review