Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: alsa-oss - Userspace OSS emulation https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209144 ------- Additional Comments From denis@xxxxxxxxxxxxx 2006-10-06 08:23 EST ------- - rpmlint ok (see below) - package name ok - packaging guidelines ok - licence is GPL, is included in %doc - source tarball matches upstream - compiles, builds, and works as expected (tested with firefox+flash) - dyn libraries handled correctly - no dir ownership issues - .so and includes in devel package - no .la in package X x86_64 issues (see below) - builds in mock Some issues: - Don't delete libossredir.a: move it to the devel package. This is a wrapper library specifically meant for static linking (that's why the static linking is hardcoded by upstream), to make oss redirection more efficient than the LD_PRELOAD "hack". I think this qualifies as a valid exception to the no-static-libs rule. - As such, you can remove the rm -fr *.a line - Add oss-redir/README to the devel package as a %doc - Missing %defattr in the %files devel section - x86_64 build suffers from rpath issues. The only fix i could find is to call 'autoreconf -f -i' before configure, and use '--disable-rpath' on the configure line (and add automake and libtool as BRs). These changes can be protected by an %ifarch x86_64. If you agree to these changes, consider the package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review