Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=553281 Terje Røsten <terjeros@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |terjeros@xxxxxxxxxxxx --- Comment #2 from Terje Røsten <terjeros@xxxxxxxxxxxx> 2010-01-07 11:57:06 EDT --- # Useless, remove %define name netsniff-ng %define version 0.5.4.1 %define release 1 Name: %{name} Version: %{version} Release: %{release}%{?dist} # don't repeat name in summary Summary: netsniff-ng is a high performance network sniffer for packet inspection # not valid License: GPL v2 # use %{version} macro here Source0: http://netsniff-ng.googlecode.com/files/netsniff-ng-0.5.4.1.tar.gz # this is strange, do %setup -q -n %{name}_%{version} %setup -q -n %{name}_%{version}/src %build # add pushd src here make %{?_smp_mflags} CFLAGS="${RPM_OPT_FLAGS}" # and these are not needed then %{__cp} ../AUTHORS ../Changelog ../COPYING ../CREDITS ../README ../TODO . %{__cp} -R ../examples . %install rm -rf $RPM_BUILD_ROOT make install DESTDIR=$RPM_BUILD_ROOT mkdir -p $RPM BINDIR_BUILD_ROOT%{_sbindir} # add BINDIR="%{_sbindir}" in %build and these will be fixed. mv $RPM_BUILD_ROOT/sbin/netsniff-ng $RPM_BUILD_ROOT%{_sbindir}/netsniff-ng %clean rm -rf $RPM_BUILD_ROOT %files %defattr(-,root,root,-) # one line is enough %doc AUTHORS ChangeLog .... %doc examples # i would do: # %doc is useless here %doc %{_mandir}/*/* # %config(noreplace) %{_sysconfdir}/netsniff-ng/*.bpf is fine. # you forgot to own %{_sysconfdir}/netsniff-ng and # %{_sysconfdir}/netsniff-ng/rules %config(noreplace) %{_sysconfdir}/netsniff-ng/rules/all_traffic.bpf %config(noreplace) %{_sysconfdir}/netsniff-ng/rules/arp.bpf %config(noreplace) %{_sysconfdir}/netsniff-ng/rules/atalk.bpf %config(noreplace) %{_sysconfdir}/netsniff-ng/rules/broadcast.bpf %config(noreplace) %{_sysconfdir}/netsniff-ng/rules/ftp.bpf %config(noreplace) %{_sysconfdir}/netsniff-ng/rules/http.bpf %config(noreplace) %{_sysconfdir}/netsniff-ng/rules/icmp.bpf %config(noreplace) %{_sysconfdir}/netsniff-ng/rules/imap.bpf %config(noreplace) %{_sysconfdir}/netsniff-ng/rules/ip_broadcast.bpf %config(noreplace) %{_sysconfdir}/netsniff-ng/rules/ip_multicast.bpf %config(noreplace) %{_sysconfdir}/netsniff-ng/rules/multicast.bpf %config(noreplace) %{_sysconfdir}/netsniff-ng/rules/pop3.bpf %config(noreplace) %{_sysconfdir}/netsniff-ng/rules/rarp.bpf %config(noreplace) %{_sysconfdir}/netsniff-ng/rules/rsync.bpf %config(noreplace) %{_sysconfdir}/netsniff-ng/rules/skype_pre.bpf %config(noreplace) %{_sysconfdir}/netsniff-ng/rules/smtp.bpf %config(noreplace) %{_sysconfdir}/netsniff-ng/rules/ssh.bpf %config(noreplace) %{_sysconfdir}/netsniff-ng/rules/vlan1000.bpf %{_sbindir}/netsniff-ng -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review