Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225985 Eric Sandeen <esandeen@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esandeen@xxxxxxxxxx --- Comment #4 from Eric Sandeen <esandeen@xxxxxxxxxx> 2010-01-06 12:12:47 EDT --- So just as a drive-by partial review, for fedora at least: rpmlint -i libaio-0.3.107-9.1.fc13.src.rpm libaio.src: W: no-url-tag The URL tag is missing. It'd be great to have: URL: http://git.kernel.org/?p=libs/libaio/libaio.git in there (or whatever the appropriate starting-point for folks looking for libaio might be...) Also, for releases that have a tarball under http://kernel.org/pub/linux/libs/aio/, please change to: Source: http://kernel.org/pub/linux/libs/aio/%{name}-%{version}.tar.gz libaio.src:33: W: setup-not-quiet Use the -q option to the %setup macro to avoid useless build output from unpacking the sources. I guess it wants "-q" ;) libaio.src:233: W: macro-in-%changelog %files Macros are expanded in %changelog too, which can in unfortunate cases lead to the package not building at all, or other subtle unexpected conditions that affect the build. Even when that doesn't happen, the expansion results in possibly "rewriting history" on subsequent package revisions and generally odd entries eg. in source rpms, which is rarely wanted. Avoid use of macros in %changelog altogether, or use two '%'s to escape them, like '%%foo'. This is due to: * Sat Apr 12 2002 Benjamin LaHaise <bcrl@xxxxxxxxxx> - add /lib/libredhat-kernel* to %files. which is trivial to fix. libaio.src: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line 55) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. ok that's just a nitpick. As for the built binaries: # rpmlint -i /root/rpmbuild/RPMS/x86_64/libaio-0.3.107-9.1.fc12.x86_64.rpm libaio.x86_64: W: no-url-tag The URL tag is missing. same as above libaio.x86_64: E: shared-lib-without-dependency-information /lib64/libaio.so.1.0.0 libaio.x86_64: E: shared-lib-without-dependency-information /lib64/libaio.so.1.0.1 1 packages and 0 specfiles checked; 2 errors, 1 warnings. this is because src/Makefile has -nostdlib -nostartfiles - I'm not sure what the point of that is... # rpmlint -i /root/rpmbuild/RPMS/x86_64/libaio-devel-0.3.107-9.1.fc12.x86_64.rpm libaio-devel.x86_64: W: no-version-dependency-on libaio/libaio-libs/liblibaio 0.3.107 libaio-devel.x86_64: W: no-url-tag The URL tag is missing. same as above. libaio-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. *shrug* 1 packages and 0 specfiles checked; 0 errors, 3 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review