[Bug 544629] at-spi2-atk - GTK+ module that bridges ATK to D-Bus at-spi

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=544629


Joshua Roys <roysjosh@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |roysjosh@xxxxxxxxx




--- Comment #2 from Joshua Roys <roysjosh@xxxxxxxxx>  2010-01-05 09:14:28 EDT ---
+ rpmlint (buildroot tag is no longer required, as long as this isn't going
into epel 5)
  $ rpmlint at-spi2-atk.spec
  at-spi2-atk.spec: W: no-buildroot-tag
  0 packages and 1 specfiles checked; 0 errors, 1 warnings.
+ package name is fine
+ spec is %{name}.spec
+ meets packaging guidelines
+ meets licensing guidelines
+ license matches (the GNU Library GPL is the precursor to the Lesser GPL)
+ COPYING is in %doc
+ spec is in American English
+ spec is legible
+ sources match
? build (I can't convince my mock to get the repodata from a mirror that has
at-spi2-core in it... but I'm assuming this builds fine)
+ no ExcludeArch
+ build deps listed
+ no locales
+ no shared libraries in default paths
+ doesn't bundle a copy of a system library
+ not relocatable
+ directories appear sane
+ %files doesn't contain duplicates
+ %files has %defattr
+ %clean is correct
+ spec macros used consistently
+ package contains code
+ no large docs
+ %doc files are not required to run
+ no header files
+ no static libraries
+ no pkgconfig files
+ .so does not have trailing numbers
+ no -devel package
+ no .la files (removed in %install phase)
+ no gui applications
+ no duplicate file/dir ownership
+ %install clears buildroot
+ filenames are valid utf-8

so long as it builds for you in mock/koji,
APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]