Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551878 --- Comment #7 from Michael Schwendt <mschwendt@xxxxxxxxx> 2010-01-03 15:49:54 EDT --- > %attr vs. chmod Hmm... there are no guidelines for everything. :) Though, %attr in the %files section is very explicit and reduces readability of the %files section. It's better to limit it to the special cases when you cannot avoid using it. That is when you need to set username, groupname, or security relevant permission bits. You want such special cases in the %files section to catch your eyes. As in "Caution! %attr is used, there's something special about that file/directory". On the contrary, using %attr only to set ordinary file access permissions is overuse of a macro. Imagine you would need to fix incorrect permissions of more files and also set special security relevant permissions on a few important files. Overuse of %attr adds "noise". The %prep section is the more convenient place where to fix ordinary access bits of files in a source tarball, e.g. using "find" commands. The .desktop file is 0755 because of a bug in the tarball's Makefile.am. Better fix it and submit the patch upstream. ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review