Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551838 --- Comment #2 from Roshan Singh <singh.roshan08@xxxxxxxxx> 2010-01-03 09:28:27 EDT --- Hi, Thanks for reviewing my package. I have removed glibc-devel. > * However, after checking the configure.in, I think you'll need to set > perl-devel as a BuildRequires. perl-ExtUtils-Embed needs perl-devel as its dependency, so i have not included it in BuildRequires. > * By the way, according to the file configure.in, the BR libcap-devel is only > required if the option « --enable-switch_user » is explicitely called. > Otherwise it is useless. > If you think that this option is useful, it may be a good thing to enable it, > to offer as many enabled features as possible in your binary. Thank you for noticing this. I have included it: %configure --enable-switch_user I have checked it with mock, it is running fine. However it was first time that I was using mock. I would like you to take a look :-). Link to updated spec and srpm: SPEC: http://roshansingh.fedorapeople.org/opendchub/opendchub.spec SRPM: http://roshansingh.fedorapeople.org/opendchub/opendchub-0.8.1-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review