Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=546451 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> 2010-01-02 02:44:33 EDT --- Please read http://fedoraproject.org/wiki/Packaging/PHP %[xmldir} => use %{pear_xmldir} HTML_Template_IT.xml => %{name}.xml %{peardir} => %{pear_phpdir} + %{pear_testdir} %{peardir}/* => please, expand to avoid to own already owned dir BuildRequires => (version which provides needed macros) php-pear >= 1:1.4.9-1.2 Requires => (missing) Requires(post): %{__pear} Requires(postun): %{__pear} Provides => (missing) Provides: php-pear(HTML_Template_IT) = %{version} %prep : no need to run pear command here, see some other php-pear-extension, could also try the pear-pear-PEAR-Command-Packaging Caution : package.xml still a V1 format which could cause some issue. I recommend to convert it to V2 during prep (see pear convert) Are you ready to maintain this package which seems not really active upstream ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review