Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226375 --- Comment #2 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2010-01-01 13:37:04 EDT --- - Change Requires: /sbin/chkconfig /sbin/service to Requires: chkconfig initscripts to speed up dependency resolution. - Patch1 but no Patch0? - Version is really 2, not 2.0. There's already an Epoch defined, so this could be rectified by an epoch bump. - Source URL should be http://downloads.sourceforge.net/gkernel/rng-tools-2.tar.gz not http://download.sourceforge.net/gkernel/rng-tools-2.tar.gz Ideally %{version} macro should be used here. - %configure picks up correct compiler flags. make CFLAGS="$RPM_OPT_FLAGS" should be make %{?_smp_mflags} to enable SMP compilation. - You can drop mkdir -p %{buildroot}%{_sbindir} mkdir -p %{buildroot}%{_initrddir} mkdir -p %{buildroot}%{_sysconfdir}/sysconfig mkdir -p %{buildroot}%{_mandir}/man{1,8} as this is automatically done by make install. - If you %define _sbindir /sbin at the top of the spec file, you can use plain %configure and %{_sbindir} in %files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review