Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226315 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jussi.lehtola@xxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |jussi.lehtola@xxxxxx Flag| |fedora-review? --- Comment #1 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2010-01-01 13:21:27 EDT --- rpmlint output: prelink.src: W: no-url-tag prelink.src:215: W: macro-in-%changelog %{_sysconfdir} prelink.src:337: W: macro-in-%changelog %{_sysconfdir} prelink.src:364: W: macro-in-%changelog %{_sysconfdir} prelink.src:384: W: macro-in-%changelog %{_sysconfdir} prelink.src:540: W: macro-in-%changelog %{_sysconfdir} prelink.src:630: W: macro-in-%changelog %{_sysconfdir} prelink.src: W: no-cleaning-of-buildroot %install prelink.x86_64: W: no-url-tag prelink.x86_64: E: statically-linked-binary /usr/sbin/prelink prelink.x86_64: W: non-conffile-in-etc /etc/rpm/macros.prelink prelink.x86_64: W: log-files-without-logrotate /var/log/prelink prelink-debuginfo.x86_64: W: no-url-tag 3 packages and 0 specfiles checked; 1 errors, 12 warnings. - Fix the above. ** - I'd move the definition %define date 20090925 to the top of the spec file, change the %define to %global and add it also to the Release field, i.e. Release: 3.%{date}%{?dist} - Modernize obsolete BuildRoot to BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) - Move tests to %check phase. - Don't use %makeinstall, it's deprecated. http://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used - Change mkdir -p %{buildroot}%{_sysconfdir}/rpm cp -a %{SOURCE2} %{buildroot}%{_sysconfdir} mkdir -p %{buildroot}%{_sysconfdir}/{sysconfig,cron.daily,prelink.conf.d} cp -a %{SOURCE3} %{buildroot}%{_sysconfdir}/cron.daily/prelink cp -a %{SOURCE4} %{buildroot}%{_sysconfdir}/sysconfig/prelink chmod 755 %{buildroot}%{_sysconfdir}/cron.daily/prelink chmod 644 %{buildroot}%{_sysconfdir}/{sysconfig/prelink,prelink.conf} to install -D -p -m 644 %{SOURCE2} %{buildroot}%{_sysconfdir}/prelink.conf install -D -p -m 755 %{SOURCE3} %{buildroot}%{_sysconfdir}/cron.daily/prelink install -D -p -m 644 %{SOURCE4} %{buildroot}%{_sysconfdir}/sysconfig/prelink install -D -p -m 644 %{SOURCE5} %{buildroot}%{_sysconfdir}/rpm/macros.prelink where the contents of cat > << EOF has been placed in SOURCE5. - Drop the %attr lines from %files, as they are unnecessary (default permissions). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review