Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=544869 Orion Poplawski <orion@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |orion@xxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |orion@xxxxxxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Orion Poplawski <orion@xxxxxxxxxxxxx> 2009-12-31 12:14:47 EDT --- * rpmlint udunits2.i686: W: shared-lib-calls-exit /usr/lib/libudunits2.so.0.0.0 exit@xxxxxxxxx A number to UCAR libraries do this - often only when a certain flag is set. Probably worth pinging upstream about though. Not blocking the review though. * naming - okay * NamingGuidelines * licensing - MIT * osi approved? yes * included? yes * correct mentioned in specfile? yes specfile * American English - yes * legible - yes * BuildRequires - good * Locales - NA * shared libraries: ldconfig - yes * %clean section with rm -rf ${RPM_BUILD_ROOT} - yes * macros - consistent * sources - checksums match upstream * relocatable? Prefix: /usr? - NA * files and directories - good * owns all created directories - yes * all files listed in %files - yes * permissions? - good * deffattr? - yes * no .la files - yes * no conflicts with other packets - checked okay with udunits * -devel - yes * headers - yes * static libraries - NA * .so without suffix when .so.suffix existent - nope * .pc files - NA * permissable content - yes * doc - yes * large doc in -doc package - NA * must not affect runtime - good * mock build - yes * sane scriptlets - yes * subpackages with fully versioned dependency - yes Looks good. Approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review