Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=550600 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #2 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-12-29 11:57:41 EDT --- For -2: * Obsoletes - (I also added some comments on bug 550594) At first I thought this package (i.e. -gui-gtk) should obsolete the old themonospot, however maybe -base should obsolete it. Anyway please add "Obsoletes: themonospot <= <specific_version>" to the proper package. Currently I am not sure if "Provides: themonosport = <some_version>" should be added or not. * Timestamps - Same as bug 550599 - Also please consider to use ---------------------------------------------------------- make DESTDIR=%{buildroot} INSTALL="install -p" install ---------------------------------------------------------- to keep timestamps on installed files as much as possible (for this package this should keep timestamp on pixmap file) This method usually works for Makefiles generated by recent autotools * desktop-file-install https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage - "--vendor="fedora" should no longer be used - you may use "--delete-original" option for desktop-file-install instead of removing desktop file firstly installed under %buildroot, or you can use desktop-file-validate instead of desktop-file-install. ! dependency against -plugin-mkv ! Currently this package "crashes" without having -plugin-mkv installed with - type $ mono --debug /usr/lib/themonospot-gui-gtk/themonospot-gui-gtk.exe - click "Folder" - On the pop-up window titled "Select folder to scan", choose a directory and click "Open" Then: --------------------------------------------------------------- [tasaka1@foo ~]$ mono --debug /usr/lib/themonospot-gui-gtk/themonospot-gui-gtk.exe OS: NON Windows configuration file path: /home/tasaka1/.themonospot.xml Unhandled Exception: System.NullReferenceException: Object reference not set to an instance of an object at ThemonospotGuiGtk.MainWindowClass.ScanFolder (System.String folderPath, Boolean recursive) [0x00000] in <filename unknown>:0 at ThemonospotGuiGtk.MainWindowClass.StartScanFolder (System.String folderPath, Boolean recursive) [0x00000] in <filename unknown>:0 at ThemonospotGuiGtk.MainWindowClass+<OpenFolder>c__AnonStorey0.<>m__0 () [0x00000] in <filename unknown>:0 --------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review