Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=550599 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-12-29 03:17:45 EDT --- Some notes: * License - There is no license information in the tarball. Would you clarify it (as you are the upstream)? * (Build)Requires - As I wrote in -base review, ">= 1.2.3" part on (Build)Requires: mono-core is not needed (for current Fedora) - Also ">= 0.8.1" part on (Build)Requires: themonospot-console is not needed either because -core packages to be intoduced into Fedora satisfies this version dependency on every Fedora branch. ref: the last sentence in https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires * %files - %files entry "%{_bindir}/%{name}/" is wrong because the last slash should mean that this %files entry is a directory, while the actually installed one is a file, not a directory. (i.e. this should be "%{_bindir}/%{name}") ! Note In reality, current rpm simply ignores the last slash. https://bugzilla.redhat.com/show_bug.cgi?id=505995 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review