Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522207 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #14 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-12-29 00:46:40 EDT --- Thanks for update. eview: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1894217 - rpmlint is NOT silent for SRPM and for RPM. pki-common.src:122: W: macro-in-%changelog %{_javadir} pki-common.src:123: W: macro-in-%changelog %{_javadir} pki-common.src:126: W: macro-in-%changelog %defattr pki-common.noarch: W: dangling-symlink /var/lib/tomcat5/common/lib/cmsutil.jar /usr/share/java/pki/cmsutil.jar pki-common.noarch: W: dangling-symlink /var/lib/tomcat5/common/lib/nsutil.jar /usr/share/java/pki/nsutil.jar ==> Fix these messages. + source files match upstream url (sha1sum) 75ae888e57aaf3bbf4956ad7eb8f4f19addb6afc pki-common-1.3.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application Suggestions: 1) please fix rpmlint messages before importing to cvs. pki-common.src:122: W: macro-in-%changelog %{_javadir} pki-common.src:123: W: macro-in-%changelog %{_javadir} pki-common.src:126: W: macro-in-%changelog %defattr ==> In Changelog, you need to write macros as %%defattr not just %defattr. same for %{_javadir}, write it as %%{_javadir} 2)pki-common.noarch: W: dangling-symlink /var/lib/tomcat5/common/lib/cmsutil.jar /usr/share/java/pki/cmsutil.jar pki-common.noarch: W: dangling-symlink /var/lib/tomcat5/common/lib/nsutil.jar /usr/share/java/pki/nsutil.jar ==> I think these are needed so can be ignored then APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review