[Bug 491497] Review Request: dmapd - A server that provides DAAP and DPAP shares

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491497





--- Comment #17 from Christian Krause <chkr@xxxxxxxxxxx>  2009-12-28 04:39:46 EDT ---
Sorry for the late answer, the December is always quite a busy month. I've
looked at the new package and I've seen the following:

- please use also %{_initdir} in this line:
install -D -m 755 distro/dmapd.fedora
%{buildroot}%{_sysconfdir}/rc.d/init.d/dmapd

- rpmlint reveals a new problem:
dmapd.i686: W: incoherent-subsys /etc/rc.d/init.d/dmapd $prog
Technically your solution seems to be OK as well, so I don't know why rpmlint
complains here...

It should be sufficient (and also not wrong) to replace 
lockfile=/var/lock/subsys/$prog
with
lockfile=/var/lock/subsys/dmapd

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]