Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517743 --- Comment #16 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2009-12-27 12:16:39 EDT --- You use 'sed -i'. Everytime you change the .desktop to contain PYTHONPATH, you destroy it, when you run rpmbuild again. (And the included .desktop does not contain PYTHONPATH again ;) ) If you upload the corrected one manually (with cvs add... and not with ./common/cvs-import.sh) this will be ok in cvs... ############### LICENSE I'm still not sure, if the license is correct. Josiah copied the LGPLv2 file and made some changes under GPLv2. ("[...] which describes which parts of itself are lgpl v2 licensed. [...]") and in the file is "adapted from", which means there where changes... LGPLv2 allows relicensing under GPLv2 (see https://fedoraproject.org/wiki/Licensing#GPL_Compatibility_Matrix ). -> Anything GPLv2 But I'm no layer. If Josiah would agree to this, it'll be ok. If not, I'd like the legal team to take a look. ###############y Anything else fine in the spec. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review