Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461119 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tomspur@xxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #6 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2009-12-27 11:02:03 EDT --- (In reply to comment #5) > I will fix > Is this a full review ? No. I didn't want to do a full review, when %files is not yet in final state; but will do the rest of it now... REVIEW: Good: - Group ok - name ok - description ok - removing *.la, ok - no static libs - libs correctly packaged (ldconfig...) - timestamps ok - parallel make - rpmlint clean - builds in koji https://koji.fedoraproject.org/koji/taskinfo?taskID=1892775 Needswork: - License is wrong: Why BSD? There are LGPLv2+ headers and COPYING. - %files Will check for permissions and so on later. - BR: - cairo-devel is missing, gets pulled in by pango-devel, but I wouldn't trust that... - check for >= 0.2.7 is not needed anymore, but ok - How about including the examples into -devel, too? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review