Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=536694 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #19 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-12-26 12:31:17 EDT --- For 4.22-1: * Requires - Again please check if writing "R: perl-foo" explicitly is really needed. ! For example when you try $ rpm -q --requires clamtk", you'll see that "perl(Locale::gettext)" is automatically detected and added to R, so writing "R: perl-gettext" is not needed. By the way with rawhide rpm (4.8.0), when you try "rpm -qv --requires clamtk", you can check what Requires are manually written in the spec file and what are automatically added by rpmbuild like: --------------------------------------------------- $ rpm -qv --requires clamtk post: /bin/sh postun: /bin/sh auto: /usr/bin/perl manual: clamav >= 0.90 manual: clamav-data manual: clamav-update manual: cronie manual: perl(:MODULE_COMPAT_5.10.1) auto: perl(Carp) auto: perl(ClamTk::App) ..... --------------------------------------------------- ! License - Not a blocker, however it is better that you update lib/GUI.pm and the corresponding gettext po files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review