[Bug 520550] Review Request: IVAN - SDL roguelike

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=520550





--- Comment #13 from Michael Schwendt <mschwendt@xxxxxxxxx>  2009-12-26 05:44:43 EDT ---
Re: comment 8

> ../../FeLib/Include/save.h:39: error: cast from 'FILE*' to 'truth' loses precision

| typedef.h:typedef int truth;
| typedef.h:typedef const int ctruth;
|
| save.h:  FILE* Buffer;
| save.h:  truth IsOpen() { return truth(Buffer); }

An attempt at creating a boolean type and really just ending with a typecast
from pointer to int. Nothing is won by not using an explicit NULL-pointer
comparison in this case.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]