Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=550143 Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cwickert@xxxxxxxxxxxxxxxxx --- Comment #5 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> 2009-12-24 05:19:41 EDT --- I'd leave both BuildRoot: and %install rm -rf $RPM_BUILD_ROOT Without it, the package will build on Fedora >= 10 only but not on EPEL or alike. The license tag is wrong. COPYING is GPLv3 and the source states "version 3 or any later version", so the tag should be GPLv3+ Please change %{_mandir}/man1/webattery.1.gz to %{_mandir}/man1/webattery.1.* because the compression of the manpages is applied automatically to the package and we might switch to something different than gz. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review