Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=550139 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #1 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2009-12-23 18:08:36 EDT --- Just some quick comments on your spec file. - You need to add 'hicolor-icon-theme' as a requirement to avoid issues with the ownership of the %{_datadir}/icons/hicolor directory - Please follow the guidelines for the installation of the .desktop file https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files - Can you please take a look at your BRs . Isn't gettext needed by intltool and didn't libgee-devel pulls in libgee. The rpmlint output [fab@localhost i686]$ rpmlint pino* pino-debuginfo.i686: E: debuginfo-without-sources 2 packages and 0 specfiles checked; 1 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review