Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=550100 --- Comment #2 from Sebastian Dziallas <sebastian@xxxxxxxx> 2009-12-23 17:15:53 EDT --- (In reply to comment #1) > Just a few comments for now, because I'm unsure, if reviewing this is the right > procedure... > > - use %global and not %define > > https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define Right, makes sense! > - permissions of buildmanifest.py need to be 664, like they where. > But this is no executable script and contains #!/usr/bin/env > Fix this with [1] to delete the shebang and not touching the permissions. > > [1] > https://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Remove_shebang_from_files I thought it should be executable since it had a main() part. Anyway, thanks for the hints! I think I'll just open another bug and try to ping the original maintainer again. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review