Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=548824 --- Comment #6 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> 2009-12-22 16:33:22 EDT --- Hi, I made a couple of changes to the source and checked them an at https://fedorahosted.org/security-spin/browser/security-menu Changes: * Rename X-Security-Lab to X-SecurityLab for better fdo compliance. Whitespces are usually just left out. * Add subcategories X-Anonymity, X-CodeAnalysis, X-Forensics, X-IntrusionDetection, X-Password-Tools, X-Reconnaissance and X-Wireless * Use TryExec to determine installed apps, see http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html * Menu tweaks * Enhance Makefile * Added AUTHORS * Added ChangeLog (for upstream changes, not packaging). Please review if my info is right! Please take a look the changes, especially what I have done for the applications included with <filename> </filename>. I think this might be needed for more apps, please check. When we are done with everything, we tag it 1.0 in git make a tarball to package. The spec looks sane, but * you should use desktop-file-validate in %install, see https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files * Don't forget to include AUTHORS and ChangeLog * Change the Source0 url to point to fedorahosted when we have a tarball there Please don't upload the rpms into git, just put them on your fedorapeople.org account while they are under review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review