Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529374 --- Comment #10 from Simon Wesp <cassmodiah@xxxxxxxxxxxxxxxxx> 2009-12-22 05:24:48 EDT --- (In reply to comment #9) > I would say this is ready for repo, now. > Simon, what do you think? I disagree with you %{_libdir}/python2.6/site-packages/gtk-2.0/_ethos.so this is ugly. please use: %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} in the head of your spec and then %{python_sitelib}/gtk-*/_%{name}.so https://fedoraproject.org/wiki/Packaging:Python you should use %{name} instead of the name and you should use the "*" instead of version numbers. It's easier for an mass rebuild; like a pygtk update. for example the new path will be gkt-3.0 your specfile is valid for this and it is nor required to edit it. Please add a / to the directories in your filelists, it's easier to differ files and directories. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review