Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=549496 Terje Røsten <terjeros@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |terjeros@xxxxxxxxxxxx --- Comment #1 from Terje Røsten <terjeros@xxxxxxxxxxxx> 2009-12-21 15:54:13 EDT --- Some random comments. a) Is summary a bit strange? Drop the leading verb? b) Useless line: %doc. Is there more info available in the package? c) I am favor of more explicit %files section, %{_libdir}/* can pick up random stuff. d) The source url is not correct, just drop %{name} macro here. e) %{_mandir}/man1/bakefil*.gz change to %{_mandir}/man1/bakefil* (compression might change to e.g. xz) f) commas in buildreq/req is just noise -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review