Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=527059 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hdegoede@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |hdegoede@xxxxxxxxxx Flag| |fedora-review? --- Comment #9 from Hans de Goede <hdegoede@xxxxxxxxxx> 2009-12-21 07:58:58 EDT --- Reviewing this one, Martin thanks for all the useful comments so far. Full review done (tarbal matches upstream, license check, spec file readability, rpmlint, etc.). I've only one remark, which is a blocker though. MUST FIX: --------- * Requires: libpulse.so.0(PULSE_0) Is wrong for 64 bit systems, which have: libpulse.so.0(PULSE_0)(64bit) The only way I see to fix this, while allowing the package to stay noarch is using: Requires: pulseaudio-libs -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review