Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=548795 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #1 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2009-12-21 05:01:53 EDT --- Just some quick comment on your spec file. - Please use '%global' instead of '%define' - Is 'Requires: python' really needed? Isn't it pulled in automatically by RPM? - '-n %{name}-%{version}' is the default. '%setup -q' is enough. - Please ask upstream to include a COPYING file. - You must use macros. Replace '/usr/bin/bel' with ' %{_bindir}/bel' https://fedoraproject.org/wiki/How_to_create_an_RPM_package#Macros - Your package provides an egg. Please have a look at the following page https://fedoraproject.org/wiki/Packaging/Python/Eggs -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review