Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=549198 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tomspur@xxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tomspur@xxxxxxxxxxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2009-12-20 18:32:19 EDT --- Review: Good: - name ok - %files section ok - permissions ok - rpmlint clean - macros everywhere - %clean is there - %doc ok - no *.la files - no libs - no gui -> no desktop file - no translations - group ok Needswork: - Have you queried upstream to include a COPYING file? If not yet, please do so. - BR: python-devel is not needed - --prefix=%{_prefix} is not needed in %install - License is GPLv3+ not GPLv3 only ####################### These are only minor issues, which are fixed easily -> appoving ####################### APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review