Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542463 Xavier Bachelot <xavier@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |xavier@xxxxxxxxxxxx Flag| |fedora-review+ --- Comment #2 from Xavier Bachelot <xavier@xxxxxxxxxxxx> 2009-12-20 17:46:05 EDT --- OK: spec file is properly named OK: package is properly named OK: Spec is legible NOK: use of macros is consistent OK: tarball match upstream : d0e625ee9b8d4823955686048ac69d0a zaz-0.3.0.tar.gz OK: License field match the actual license and is acceptable Ok: BuildRoot is correct OK: BuildRequires and Requires are correct OK: no bundled copied of libraries OK: Desktop file is validated and installed OK: scriplets are correct. OK: locales are properly handled OK: defattr is correct OK: %doc is correct Ok: builds in mock OK: all files and directories are properly packaged Ok: doesn't own dirs it shouldn't OK: files/dirs perms are correct OK; rpmlint output is clean ; zaz.i686: W: dangling-symlink /usr/share/zaz/FreeSans.ttf /usr/share/fonts/gnu-free/FreeSans.ttf zaz.i686: W: dangling-symlink /usr/share/zaz/font1.ttf /usr/share/fonts/oflb-dignas-handwriting/phranzysko_-_Digna_s_Handwriting.ttf zaz.i686: W: dangling-symlink /usr/share/zaz/FreeMonoBold.ttf /usr/share/fonts/gnu-free/FreeMonoBold.ttf 3 packages and 0 specfiles checked; 0 errors, 3 warnings. These 3 are expected and can be ignored. Ok: final provides and requires are correct Note : typo in %prep section : # Fix premissions ^^ Please fix use of macros, there is a spurious %{buildroot} when installing the icon, then this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review