Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532306 --- Comment #9 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-12-20 15:06:52 EDT --- Created an attachment (id=379509) --> (https://bugzilla.redhat.com/attachment.cgi?id=379509) Patch for ruby-debug to use system-wide -base and test fix Ah... (In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > - Please create one srpm per one gem. > > > > These gems do not distribute very well separately, they have the same upstream > > and one requires the other in a %{version}-%{release} specific manner. > > - Ah, I checked two gems and actually dependency is in loop... Well, I checked these two gems' dependency again and actually ruby-debug-base does not require ruby-debug ( ruby-debug-base-0.10.3/test/base/base.rb has "require 'ruby_debug'" for example, but this is satisfied by "ruby_debug.so" in ruby-debug-base (and not by ruby-debug.rb in ruby-debug gem) ) Also "rake test" under ruby-debug-base succeeds without ruby-debug gem. So still ruby-debug-base and ruby-debug should be packaged seperately. (ruby-debug-base does not depend on ruby-debug but ruby-debug does depend on ruby-debug-base) For ruby-debug, currently your spec file contains: --------------------------------------------------------- 99 %check 100 pushd %{_builddir}/%{name}-%{version}/%{geminstdir2} 101 rake -f ../ruby-debug-0.10.3/Rakefile test --------------------------------------------------------- This skips many tests, because ruby-debug Rakefile contains --------------------------------------------------------- 27 CLI_TEST_FILE_LIST = FileList['test/cli/commands/unit/*.rb', 28 'test/cli/commands/*_test.rb', 29 'test/cli/**/*_test.rb', 30 'test/test-*.rb'] 61 t.test_files = CLI_TEST_FILE_LIST ---------------------------------------------------------- however many of these files cannot be detected if the working directory is ./%{geminstdir2}, not ./%{geminstdir}. "rake test" for ruby-debug should be done under .%{geminstdir}. Note that when executing "rake test" correctly under ./%{geminstdir} many tests fail and patch is needed (attached). After applying patch: ----------------------------------------------------------- [tasaka1@localhost ruby-debug-0.10.3]$ rake test (in /home/tasaka1/rpmbuild/Reviewing/rubygem-related/rubygem-ruby-debug/rubygem-ruby-debug-0.10.3-4.fc12.src/TMP2/DEBUGINSTDIR/gems/ruby-debug-0.10.3) ruby_debug already installed, skipping creating shared library extension /usr/bin/ruby -I"lib:./ext:./lib" "/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader.rb" "test/base/base.rb" "test/base/binding.rb" "test/base/catchpoint.rb" Loaded suite /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader Started ..... Finished in 0.003895 seconds. 5 tests, 30 assertions, 0 failures, 0 errors /usr/bin/ruby -I"lib:./ext:./lib:./cli" "/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader.rb" "test/cli/commands/unit/regexp.rb" "test/cli/commands/catchpoint_test.rb" "test/cli/commands/catchpoint_test.rb" "test/test-edit.rb" "test/test-info.rb" "test/test-source.rb" "test/test-annotate.rb" "test/test-ctrl.rb" "test/test-list.rb" "test/test-catch.rb" "test/test-save.rb" "test/test-info-thread.rb" "test/test-emacs-basic.rb" "test/test-quit.rb" "test/test-init.rb" "test/test-method.rb" "test/test-info-var.rb" "test/test-output.rb" "test/test-trace.rb" "test/test-setshow.rb" "test/test-help.rb" "test/test-hist.rb" "test/test-raise.rb" "test/test-breakpoints.rb" "test/test-finish.rb" "test/test-stepping.rb" "test/test-frame.rb" "test/test-condition.rb" "test/test-enable.rb" "test/test-display.rb" "test/test-dollar-0.rb" "test/test-break-bad.rb" "test/test-pm.rb" Loaded suite /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader Started .........................Skipping method sig test .......... Finished in 18.947538 seconds. 35 tests, 46 assertions, 0 failures, 0 errors ----------------------------------------------------------- Currently only the first 5 tests are executed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review