Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Glom - Database designer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201437 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-10-03 22:11 EST ------- OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 55e5b35d268e342ed5305e9c798856a4 glom-1.0.5.tar.bz2 55e5b35d268e342ed5305e9c798856a4 glom-1.0.5.tar.bz2.1 See below - Package compiles and builds on at least one arch. See below - BuildRequires correct OK - Spec handles locales/find_lang OK - Spec has needed ldconfig in post and postun OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package is a GUI app and has a .desktop file OK - Package doesn't own any directories other packages own. See below - No rpmlint output. SHOULD Items: OK - Should include License or ask upstream to include it. See below - Should build in mock. Issues: 1. package doesn't build in mock. build.log has: checking for GDU_MODULE_VERSION_CHECK... configure: error: Package requirements (gnome-doc-utils >= 0.3.2) were not met: No package 'gnome-doc-utils' found Missing 'BuildRequires: gnome-doc-utils' ? Adding that gets a failure with: No package 'pygda-1.2' found No package 'libgnome-2.0' found Your 'BuildRequires: gnome-python2-gda' might need to be gnome-python2-gda- devel? You might also need 'BuildRequires: libgnome-devel' ? Adding those it builds here. 2. Your configure has '--disable-scrollkeeper'. Is it worth including scrollkeeper docs? 3. rpmlint on x86_64 says: E: glom binary-or-shlib-defines-rpath /usr/lib64/python2.4/site-packages/ glom.so ['/usr/lib64'] E: glom binary-or-shlib-defines-rpath /usr/bin/glom ['/usr/lib64'] Perhaps a --disable-rpath? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review