Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225709 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #8 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2009-12-18 09:56:20 EDT --- That's what https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define says: """Use %global instead of %define, unless you really need only locally defined submacros within other macro definitions (a very rare case). """ In this case, it won't be a problem to use %define and not %global, but if FESCo decides to ust %global everywhere and not %define, we should simply get used to it or feel free to complain at https://fedorahosted.org/fesco/ If you use some %ifs or %{!?foo: ... } constructs and %define something in it, this could be gone, if you are out of the %if again, but still need it. Sometimes rpm removes the %define again, sometimes not... That's the main reason, why not using %define. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review