[Bug 538296] Review Request: openvas-libnasl - Support for NASL scripting language in OpenVAS Server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538296


Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
               Flag|                            |fedora-review+




--- Comment #8 from Parag AN(पराग) <panemade@xxxxxxxxx>  2009-12-18 06:14:53 EDT ---

eview:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1879210
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
7a4342418de2a591353a4404455ca97a49d589d8  openvas-libnasl-2.0.2.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no .pc file present.
+ -devel subpackage present.
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package openvas-libnasl-2.0.2-3.fc13.i686 =>
Provides: libopenvasnasl.so.2
Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.3)
libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libgcrypt.so.11
libgcrypt.so.11(GCRYPT_1.2) libglib-2.0.so.0 libgnutls.so.26
libgnutls.so.26(GNUTLS_1_4) libgpg-error.so.0 libgpgme.so.11
libgpgme.so.11(GPGME_1.0) libgpgme.so.11(GPGME_1.1) libnsl.so.1 libopenvas.so.2
libopenvas_hg.so.2 libopenvasnasl.so.2 libpcap.so.1 libresolv.so.2 libutil.so.1
rtld(GNU_HASH)
+ Package openvas-libnasl-devel-2.0.2-3.fc13.i686 =>
Requires: /bin/sh libopenvasnasl.so.2
+ Not a GUI application

Suggestions:
1) I see some documentation still there. See if you can add that to spec.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]