Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226101 --- Comment #7 from Nikola Pajkovsky <npajkovs@xxxxxxxxxx> 2009-12-17 08:45:10 EDT --- (In reply to comment #5) > npajkovs, may I assume you will take care if this ? > > As for the review, Thanks! > > Here is my take on things which need fixing: > > (In reply to comment #4) > > [NO] specfile uses macros consistently: %{SOURCEx} should probably be > > %{sourcex}, "Buildroot:" -> "BuildRoot:" > > Writing SOURCE with all caps is quite normal in spec files (most do > it this way), and is allowed as long as it is in all caps everywhere > inside the specfile, which it is. > > The buildroot thingie should be fixed. > > [NO] rpmlint is silent > > > > $ rpmlint *.rpm > > lm_sensors.i686: W: dangerous-command-in-%pre mv > > lm_sensors.i686: W: dangerous-command-in-%trigger mv > > lm_sensors.i686: W: dangerous-command-in-%trigger mv > > lm_sensors.i686: W: one-line-command-in-%trigger > > /usr/bin/sysconfig-lm_sensors-convert > > These can all be ignored > ignored > > lm_sensors-libs.i686: W: summary-not-capitalized lm_sensors core libraries > > Should be fixed > fixed > > lm_sensors-libs.i686: W: shared-lib-calls-exit /usr/lib/libsensors.so.4.2.0 > > exit@xxxxxxxxx > > lm_sensors-libs.i686: W: no-documentation > > Can be ignored ignored > > lm_sensors-libs.i686: E: library-without-ldconfig-postin > > /usr/lib/libsensors.so.4.2.0 > > lm_sensors-libs.i686: E: library-without-ldconfig-postun > fixed > Oops, see below. > > > /usr/lib/libsensors.so.4.2.0 > > lm_sensors-sensord.i686: E: incoherent-subsys /etc/rc.d/init.d/sensord > > lm_sensors > > lm_sensors-sensord.i686: W: incoherent-init-script-name sensord > > ('lm_sensors-sensord', 'lm_sensors-sensordd') > > Can be ignored. ignored. we will use same name as upstream > > Imho the following lines should be added to the spec file: > > %post libs -p /sbin/ldconfig > > %postun libs -p /sbin/ldconfig > > > > Correct, and the ld_config from the main package %post should removed > > And the main package's: > %postun -p /sbin/ldconfig > > Should be removed completely. > fixed > > [???] Please consider using "Requires: dmidecode" instead of "Requires: > > /usr/sbin/dmidecode" > > No need to not use file requires when the files are in one of /bin, /sbin, > /usr/bin, /usr/sbin. > ignored > > [???] %defattr(-,root,root,-) should be used instead of %defattr(-,root,root) > > Can / should be fixed. > fixed > Regards, > > Hans -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review