Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529423 --- Comment #6 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2009-12-17 08:14:34 EDT --- Review: + builds fine in Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1877023 + rpmlint is NOT silent [petro@Workplace ~]$ rpmlint Desktop/mingw32-Open* mingw32-OpenSceneGraph.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libosg.dll.a mingw32-OpenSceneGraph.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgGA.dll.a mingw32-OpenSceneGraph.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgTerrain.dll.a mingw32-OpenSceneGraph.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgParticle.dll.a mingw32-OpenSceneGraph.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgDB.dll.a mingw32-OpenSceneGraph.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgShadow.dll.a mingw32-OpenSceneGraph.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgFX.dll.a mingw32-OpenSceneGraph.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgText.dll.a mingw32-OpenSceneGraph.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgAnimation.dll.a mingw32-OpenSceneGraph.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgManipulator.dll.a mingw32-OpenSceneGraph.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgSim.dll.a mingw32-OpenSceneGraph.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgUtil.dll.a mingw32-OpenSceneGraph.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgVolume.dll.a mingw32-OpenSceneGraph.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgViewer.dll.a mingw32-OpenSceneGraph.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgWidget.dll.a mingw32-OpenSceneGraph.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libosg.dll.a mingw32-OpenSceneGraph.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgGA.dll.a mingw32-OpenSceneGraph.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgTerrain.dll.a mingw32-OpenSceneGraph.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgParticle.dll.a mingw32-OpenSceneGraph.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgDB.dll.a mingw32-OpenSceneGraph.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgShadow.dll.a mingw32-OpenSceneGraph.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgFX.dll.a mingw32-OpenSceneGraph.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgText.dll.a mingw32-OpenSceneGraph.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgAnimation.dll.a mingw32-OpenSceneGraph.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgManipulator.dll.a mingw32-OpenSceneGraph.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgSim.dll.a mingw32-OpenSceneGraph.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgUtil.dll.a mingw32-OpenSceneGraph.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/pkgconfig/openscenegraph.pc mingw32-OpenSceneGraph.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgVolume.dll.a mingw32-OpenSceneGraph.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgViewer.dll.a mingw32-OpenSceneGraph.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libosgWidget.dll.a mingw32-OpenSceneGraph.noarch: W: non-standard-dir-in-usr i686-pc-mingw32 mingw32-OpenThreads.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libOpenThreads.dll.a mingw32-OpenThreads.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/pkgconfig/openthreads.pc mingw32-OpenThreads.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libOpenThreads.dll.a mingw32-OpenThreads.noarch: W: non-standard-dir-in-usr i686-pc-mingw32 2 packages and 0 specfiles checked; 16 errors, 20 warnings. [petro@Workplace ~]$ However all these messages may be omitted in case of mingw32-package. + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license. + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL. [petro@Sulaco SOURCES]$ sha256sum OpenSceneGraph-2.8.2.zip* 0903e3a29eba07856c563d1b313f6b803bee702e9145a27677d8dcab57db98ab OpenSceneGraph-2.8.2.zip 0903e3a29eba07856c563d1b313f6b803bee702e9145a27677d8dcab57db98ab OpenSceneGraph-2.8.2.zip.1 [petro@Sulaco SOURCES]$ + The package successfully compiles and builds into binary rpms on at least one primary architecture. See link above. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No need to run ldconfig for mingw32 libraries. + The package does NOT bundle copies of system libraries. + The package is not designed to be relocatable. - The package MUST own all directories that it creates. Unfortunately it doesn't own %{_mingw32_bindir}/osgPlugins-%{apivers} directory. Please, fix it. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No need to separate header files from main package for mingw32-related package. 0 No static libraries. 0 No need to require pkgconfig for pkgconfig(.pc) files in mingw32-related packages. 0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1). 0 No devel sub-package for mingw32 packages, since they are intended for devel entirely. 0 The mingw32 package may contain necessary .la libtool archives. This is not a blocker. 0 Not a GUI application. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8. So, please fix the only issue found by me, and I'll continue. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review