Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522208 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review+ --- Comment #5 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-12-17 02:04:13 EDT --- Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1876549 + rpmlint is silent for SRPM and for RPM. + source files match upstream url (sha1sum) fafcf9fae985c40a84d65389a0f78a73444ab038 dogtag-pki-ca-ui-1.3.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application Suggestions: 1) Before importing package in cvs, please remove Requires: bash APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review