Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547226 --- Comment #2 from Florent LC <louizatakk@xxxxxxxxxxxxxxxxx> 2009-12-16 11:25:56 EDT --- Thank you for your review (In reply to comment #1) > You'll also want to consider adding this as blocks FE-NEEDSPONSOR > (https://bugzilla.redhat.com/showdependencytree.cgi?id=FE-NEEDSPONSOR) > Ok, thanks, it's done. > - MUST: A package must own all directories that it creates. If it does not > create a directory that it uses, then it should require a package which does > create that directory. [13] > > you %files section contains: > > %{python_sitelib}/* > %{_bindir}/* > > this states that your package owns all of the contents of /usr/bin and > /usr/lib/python2.6/site-packages/ this is incorrect, please specify the > files/directories it does own. > I don't see what's wrong with this section. According to this page : https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25files_section "Note that "%{_bindir}/*" does not claim that this package owns the /usr/bin directory - it claims that all the files that were installed inside the build root 's /usr/bin are owned by the package." This states that my package claims ownership of the files it installed in the %{buildroot}/usr/bin directory. That's different from the "real" /usr/bin directory. This makes it clear too: "Claiming ownership of "%{_bindir}/*" is fine, though; that just claims ownership of the subdirectories and files you placed under %{buildroot}/%{_bindir}." What did I miss? > - MUST: Packages containing GUI applications must include a %{name}.desktop > file, and that file must be properly installed with desktop-file-install in the > %install section. If you feel that your packaged GUI application does not need > a .desktop file, you must put a comment in the spec file with your explanation. > [24] > > Your package has a GUI (specifigcally leveledit and tileedit), but no desktop > file > My package has indeed GUIs, but I don't think it should include a GUI because these GUIs are only examples for devs and NOT useful programs for the end-user. I don't think that having one or two new menu-entry whenever an user installs a game that has python-pgu as a dependency is a good thing. The different solutions I see for this problem are: - Move these examples in a different package (like python-pgu-examples?) - Just remove these examples from the package - just leave them in the package and add a comment explaining why there's no .desktop file What do you think should be done? > - MUST: Packages must not own files or directories already owned by other > packages. The rule of thumb here is that the first package to be installed > should own the files or directories that other packages may rely upon. This > means, for example, that no package in Fedora should ever share ownership with > any of the files or directories owned by the filesystem or man package. If you > feel that you have a good reason to own a file or directory that another > package owns, then please present that at package review time. [25] > > see comments above > See answer above -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review