Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530090 --- Comment #58 from Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> 2009-12-16 09:56:55 EDT --- (In reply to comment #56) > > See comments #20 to #23 above. So you are changing your mind? > Well, I have no problems with having the patches in separate diff file, but the > reviewer/sponsor feels that the patch is big and needs to be integrated with > the orig.tar.gz :-) . The Fedora policies says, that patches which are not Fedora specific should be forwarded to upstream for integration into the main sources. Because the big diff files seams to be a patch which is not Fedora specific, it may be nice if we can got integrate it into the main sources. The advance of integrate the patch into the main sources are: 1.) Better maintainmence for the packages 2.) Clarification that this is part of the common upstream distribution of the software Of courses it's not a blocker to have such big patch in the package as long as you have tried to sent this patch to upstream and have documented this in a comment in the SPEC file. Best Regards: Jochen Schmitt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review